-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "Replace in Files" dialog button text #97461
Improve "Replace in Files" dialog button text #97461
Conversation
ae02f01
to
b3bb9e7
Compare
Note that the third button does more than "ignore external changes". It also resave the file immediately. |
b3bb9e7
to
ce081a8
Compare
ce081a8
to
b9ce6c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current buttons are fine for what they are. At most, "Reload from disk" sounds good. I'm neutral on these changes. The only objectively good change is splitting "What action should be taken?" onto another line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
To be fair, whenever this kind of dialog has its labels changed, it regularly ends up in a "whack-a-mole" situation where the new label clears some of the confusion but also adds more confusion for users who understood the previous labels better. I expect we will need to do further iteration on this.
I think the new labels here a slight upgrade overall still.
Thanks! |
It re-saves everything. Any opened scene will be saved when you ignore changes, even if they weren't among the changed files. |
Showcase clearer dialog when files are changed externally on disk (#96930).
Previous
Current