Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Replace in Files" dialog button text #97461

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

lalitshankarchowdhury
Copy link
Contributor

@lalitshankarchowdhury lalitshankarchowdhury commented Sep 25, 2024

Showcase clearer dialog when files are changed externally on disk (#96930).

Previous

image

Current

image

@timothyqiu
Copy link
Member

Note that the third button does more than "ignore external changes". It also resave the file immediately.

@lalitshankarchowdhury
Copy link
Contributor Author

lalitshankarchowdhury commented Sep 26, 2024

I think it's kind of expected that Godot will overwrite external changes. This is what XCode has to say:

@lalitshankarchowdhury
Copy link
Contributor Author

I am thinking of two alternatives:

Like XCode

image

Slight modification

image

I prefer XCode like. What does the community think?

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current buttons are fine for what they are. At most, "Reload from disk" sounds good. I'm neutral on these changes. The only objectively good change is splitting "What action should be taken?" onto another line.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

To be fair, whenever this kind of dialog has its labels changed, it regularly ends up in a "whack-a-mole" situation where the new label clears some of the confusion but also adds more confusion for users who understood the previous labels better. I expect we will need to do further iteration on this.

I think the new labels here a slight upgrade overall still.

@Mickeon Mickeon modified the milestones: 4.x, 4.4 Nov 14, 2024
@lalitshankarchowdhury
Copy link
Contributor Author

For reference, here's what Visual Studio says:

image

I feel like our current version is quite clear regarding both XCode and VS.

@Repiteo Repiteo merged commit a595ae2 into godotengine:master Nov 14, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 14, 2024

Thanks!

@KoBeWi
Copy link
Member

KoBeWi commented Nov 22, 2024

Note that the third button does more than "ignore external changes". It also resave the file immediately.

It re-saves everything. Any opened scene will be saved when you ignore changes, even if they weren't among the changed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants