Improve quality of mesh and material resource previews in the editor #97468
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a combination of MSAA and SSAA to make thumbnails smoother while also improving texture sampling quality. Thumbnail generation time is largely unaffected since most of the time is spent doing things on the CPU anyway, and the thumbnail resolution is still 128×128 (although the 3D buffer is internally 256×256 now).
radiantgurl
approved these changes
Sep 27, 2024
|
Duplicate of #94573 ? |
I feel like this PR should supersede that one |
ryevdokimov
approved these changes
Dec 14, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a combination of MSAA and SSAA to make thumbnails smoother while also improving texture sampling quality1. Thumbnail generation time is largely unaffected since most of the time is spent doing things on the CPU anyway, and the thumbnail resolution is still 128×128 (although the 3D buffer is internally 256×256 now).
Tested in all rendering methods.
Preview
Mesh
Material
At 200% editor scale, thumbnails can look really clean now:
Footnotes
Texture sampling improves thanks to SSAA, which works on textures that are viewed from any angle, including head-on angles (something anisotropic filtering cannot handle). ↩