-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Vector4.components
-> coord
for consistency
#97487
Conversation
For the engine itself this isn't compatibility breaking as we don't provide compatibility guarantees for the engine internals (only the exposed API) Adding a review request for GDExtension as this is related to the godot-cpp side PR and is relevant for deciding either way |
From the perspective of godot-cpp, if we want to maintain source compatibility, we could keep both declarations in the In any case, I think it's fine to move forward with this on the Godot-side, and we can have the "maintain source compatibility for |
Vector4.components
-> coord
for consistency
We tend to use full names so instead of coord -> coordinates, but this was an internal that was exposed.. Not sure what to do. Edited: At this point adding components to all the other types is also a valid diff. |
I'd be ok with switching to |
I think this change is fine as is, I wouldn't change all Vector types further. If we're to change I'd go one step further and make this a private member so we don't even need to bother about its name or compatibility, but that'd be a Godot 5 change :) |
Thanks! |
This brings it in line with all the other vectors:
I'm guessing this naming happened when Vector4 was copied from Color, as it's essentially the same struct layout, just with different functions.
This is obviously a potentially breaking change. I didn't find any other references in core to 'components', though at least godot-cpp has named their
Vector4.components
property after this one (see godotengine/godot-cpp#1608), so godot-cpp users may be affected.