Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDExtension: Use loader to check if the library exists. #97532

Merged
merged 1 commit into from
Oct 1, 2024
Merged

GDExtension: Use loader to check if the library exists. #97532

merged 1 commit into from
Oct 1, 2024

Conversation

kisg
Copy link
Contributor

@kisg kisg commented Sep 27, 2024

This is a prerequisite to supporting extensions not implemented in regular files.

@kisg kisg requested a review from a team as a code owner September 27, 2024 10:26
@Chaosus Chaosus added this to the 4.4 milestone Sep 27, 2024
dsnopek
dsnopek reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Overall, I think this is change makes sense. Aside from the note from RedMser, the only additional note I have is about the method name.

@kisg kisg force-pushed the use_loader_library_check branch from 105292b to 8a41b1d Compare September 29, 2024 05:50
@kisg
Copy link
Contributor Author

kisg commented Sep 29, 2024

Review comments fixed and rebased.

dsnopek
dsnopek approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@akien-mga akien-mga merged commit 3b17e34 into godotengine:master Oct 1, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@cslfrd cslfrd mentioned this pull request Oct 7, 2024
Closed
@kisg kisg deleted the use_loader_library_check branch October 15, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedMser RedMser RedMser left review comments

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement topic:gdextension
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@kisg @akien-mga @dsnopek @RedMser @Chaosus