[Core] Add missing HashMapComparatorDefault cases
#97550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably add these as methods on Done: |
|
Realized Could probably add for the following as well:
Matching the code in But unsure if these are necessary or used |
AThousandShips
changed the title
HashMapComparatorDefault<Vector4>HashMapComparatorDefault for Vector4, Quaternion, and Color
AThousandShips
force-pushed
the
hash_fix
branch
2 times, most recently
from
d0a45e4 to
29c2261
Compare
|
I'd go ahead and add it for all of the Variant math structs; don't see any real reason not to do so. |
|
Will do! It'll ensure complete stability |
Added for: * `AABB` * `Basis` * `Color` * `Plane` * `Projection` * `Quaternion` * `Rect2` * `Transform2D` * `Transform3D` * `Vector4` Ensures these handles `NaN` correctly
AThousandShips
force-pushed
the
hash_fix
branch
from
29c2261 to
75cb353
Compare
AThousandShips
changed the title
HashMapComparatorDefault for Vector4, Quaternion, and ColorHashMapComparatorDefault cases
AThousandShips
commented
Sep 28, 2024
| template <> | ||
| struct HashMapComparatorDefault<Rect2> { | ||
| static bool compare(const Rect2 &p_lhs, const Rect2 &p_rhs) { | ||
| return HashMapComparatorDefault<Vector2>().compare(p_lhs.position, p_rhs.position) && HashMapComparatorDefault<Vector2>().compare(p_lhs.size, p_rhs.size); |
There was a problem hiding this comment.
Delegated here to avoid very complex expressions (will hopefully be unnecessary with #97553)
AThousandShips
commented
Sep 28, 2024
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added for:
AABBBasisColorPlaneProjectionQuaternionRect2Transform2DTransform3DVector4Ensures these handle
NaNcorrectly