Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioStreamImport: Allow waveform resize #97551

Merged

Conversation

lalitshankarchowdhury
Copy link
Contributor

@lalitshankarchowdhury lalitshankarchowdhury commented Sep 27, 2024

Allow waveform view to resize according to dialog size change:

Before Now
image  image

Production edit: set the images in a table for easier comprehension

@lalitshankarchowdhury
Copy link
Contributor Author

@AThousandShips can I get an update on this? I'm not sure who to ping for @godotengine/import.

@AThousandShips
Copy link
Member

You don't need to ping anyone, someone will check this but it's the weekend, please join the contributor chat as well and you can ask there

Copy link
Contributor

@huwpascoe huwpascoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to merge.

Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall.

@adamscott adamscott modified the milestones: 4.x, 4.4 Oct 25, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Repiteo Repiteo merged commit 204f589 into godotengine:master Nov 11, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 11, 2024

Thanks!

@lalitshankarchowdhury lalitshankarchowdhury deleted the resize-audio-waveform branch November 12, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants