Combine texture and instance data into one uniform set in the 2D renderer #97554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erer Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>
akien-mga
approved these changes
Sep 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #97341
Many mobile devices only support 4 uniform sets, so we need to be cautious to ensure that we don't use more than that.
Basically this PR defers the creation of the texture uniforms until right before we draw the batch so they can be combined with the instance data.
This extracts part of the reorganization done in #97340. Stuart did most of the work already that was necessary for this PR. The purpose of this PR is to fix the bug so we can release another dev build and give Stuart a bit more time to perfect #97340