Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract common check functions in windows_detect.py file #97556

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Extract common check functions in windows_detect.py file #97556

merged 1 commit into from
Oct 24, 2024

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Sep 27, 2024

I m not sure it should be merged. It is kinda easier to understand code without this pr so ¯\_(ツ)_/¯

@dustdfg
Extract common check functions in windows_detect.py file
Loading
Loading status checks…
9c50312 
Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
@dustdfg dustdfg requested a review from a team as a code owner September 27, 2024 18:45
@Chaosus Chaosus added this to the 4.4 milestone Sep 27, 2024
Calinou
Calinou approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 44fa552), it works as expected. This makes sense to avoid a bit of code repetition.

@Repiteo Repiteo merged commit 14d201a into godotengine:master Oct 24, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 24, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou

Assignees
No one assigned
Labels
enhancement platform:windows topic:buildsystem
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@dustdfg @Repiteo @Calinou @Chaosus