SCons: Bump C standard: C11→C17
#97626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
approved these changes
Oct 15, 2024
|
This should probably be done in godot-cpp and godot-cpp-template as well. |
|
Good call! Those should get the extra msvc C-Standard checks at the same time; I'll look into that sometime tomorrow |
|
Will this allow for some more compiler optimizations when building? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the leap from C11 to C17 is fairly minor, functioning mostly as a bugfix release1, it feels like a reasonable addition now that the C-Standard is properly added in msvc builds. The only context where the C-Standard wouldn't be updated is for anyone using VS2017, but they're already not specifying a C-Standard outright so it's not exactly dealbreaking.
Footnotes
https://en.wikipedia.org/wiki/C17_(C_standard_revision)#Changes_from_C11 ↩