-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android editor] Enable automatic install of exported apks for the Android editor #97631
[Android editor] Enable automatic install of exported apks for the Android editor #97631
Conversation
Can you add Gradle build support for Android Editor? It will be vary useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on a Samsung Galaxy Z Fold4 running Android 14, it works as expected. I've only tested the debug export, as release export can't be done using the built-in debug keystore (the autogenerated keystore path starting with assets://
isn't considered valid in the Export dialog).
The exported project (Truck Town in this case) runs successfully after installation.
Code looks good to me.
PS: In the future, we could integrate similar "run after export" options for desktop and web platforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep it's default to false
.
Auto-installing by default might inadvertently replace an existing version of the app on the device, which could be disruptive if the installed version contains different configurations or data that user want to keep separate from the newly exported build.
I am not sure I understand the concern:
|
I personally use my own apps, and during development there are many times when I make breaking changes that can also lead to corruption of the saved data. That's why I test my apps on a new user profile. I believe keeping this feature enabled by default could lead to unwanted installations if users aren't aware of it.
Oh, I wasn't aware of that. If a dialog is shown, then it should be fine. |
fd6c451
to
af2423b
Compare
@syntaxerror247 I've updated the description with a video of the install flow for illustration. |
Thanks! |
Adds support for automatically installing the exported APK for the Android editor.
An editor setting is added as well to allow enabling / disabling the feature (enabled by default).
1000059686.mp4