-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Vector to LocalVector in animation system #97687
Conversation
oops, I forget to check dev_mode, now tested locally. |
I didn't see any major problems, but I haven't tested. |
Is this PR still needed? It has been no feedback for several months. I'm going to close this if no body want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, sorry for the lack of feedback. I have been using this in testing in a custom build for a weeks now and while there could be some nuances of this new approach I may not have fully evaluated the implications of, I haven't noticed any obvious issues with the animation system which seem related to it. I'll approve it for merging, but I'll also ping @TokageItLab in case you have any thoughts on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just be sure to squash your commits first
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Thanks! |
Implement godotengine/godot-proposals#10594
convert all
Vector
I found inanimation_tree.h
andanimation_blend_tree.h
except:connections
: they involve a copy which may benifit from COWget_editable_animation_list
: seems like an interfaceTested with godot-benchmark, no noticeable performance change. Is this change acceptable as a codestyle improvement?
Build with
scons target=template_release production=yes
, run with.\godot.windows.template_release.x86_64.console.exe .\godot-benchmarks\project.godot -- --run-benchmarks --include-benchmarks="animation/animated_models/*"
Test Result: