Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display proper message on invalid folder path #97706

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

lalitshankarchowdhury
Copy link
Contributor

When creating a new folder from Import > New folder or Scan > New folder, the message displayed on empty or path with whitespaces is this:

Screenshot 2024-10-01 233024

The PR fixes this to:

Screenshot 2024-10-01 232208

@KoBeWi
Copy link
Member

KoBeWi commented Oct 15, 2024

I think EditorFileDialog should just use DirectoryCreateDialog for creating folders. It's much friendlier to use than random dialog with only LineEdit.

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself is correct though.

@Repiteo Repiteo modified the milestones: 4.x, 4.4 Oct 16, 2024
@Repiteo
Copy link
Contributor

Repiteo commented Oct 16, 2024

The commits need to be squashed into one before this can be merged. See here for one explanation on how to do do that.

@Repiteo Repiteo merged commit 975f422 into godotengine:master Oct 21, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2024

Thanks!

@lalitshankarchowdhury lalitshankarchowdhury deleted the fix-create-folder branch November 21, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants