Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltip message of button that opens groups/signals dock #97722

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix tooltip message of button that opens groups/signals dock #97722

merged 1 commit into from
Nov 11, 2024

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Oct 2, 2024 •
edited by AThousandShips
Loading

Fixes #97681

@dustdfg dustdfg requested review from a team as code owners October 2, 2024 10:17
@AThousandShips AThousandShips added bug topic:editor cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 2, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 2, 2024
@dustdfg @AThousandShips
Fix tooltip message of button that opens groups/signals dock
4a5ae8c 
Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
@dustdfg dustdfg force-pushed the fix_wrong_groups_tooltip branch from 316196f to 4a5ae8c Compare October 2, 2024 10:35
@aryan-11825114
Copy link
Contributor

aryan-11825114 commented Oct 4, 2024 •
edited
Loading

I was wondering what would be the case if both group and signal is present, wouldn't it be better if it said "Click to show node dock" for signal and group both?

Screenshot from 2024-10-04 18-13-02

@dustdfg
Copy link
Contributor Author

dustdfg commented Oct 4, 2024 •
edited
Loading

I was wondering what would be the case if both group and signal is present, wouldn't it be better if it said "Click to show node dock" for signal and group both?

I also though about it but anyway by clicking on the button you will open one of the tabs and you'd better to show user exactly what tab you will open

@aryan-11825114
Copy link
Contributor

I was wondering what would be the case if both group and signal is present, wouldn't it be better if it said "Click to show node dock" for signal and group both?

I also though about it but anyway by clicking on the you will open one of the tabs and you'd better to show user exactly what tab you will open

I see, it seems logically good that way 👍

@Repiteo Repiteo merged commit 5633556 into godotengine:master Nov 11, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 11, 2024

Thanks!

@dustdfg dustdfg deleted the fix_wrong_groups_tooltip branch November 11, 2024 21:53
@Spartan322 Spartan322 mentioned this pull request Jan 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Wrong message on the Groups Icon in the Scene View
5 participants
@dustdfg @aryan-11825114 @Repiteo @KoBeWi @AThousandShips