[Web] Make audio bus fetching more resilient to errors #97739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
added
bug
platform:web
topic:porting
topic:audio
cherrypick:4.3
adamscott
force-pushed
the
fix-get-bus-null
branch
from
bd6069d to
7a634ad
Compare
akien-mga
approved these changes
Oct 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes audio bus fetching more resilient to null errors. Sometimes, the engine can send an erroneous bus, so the JavaScript code used to trip over an invalid index. Now, with this fix, there are now checks in place in areas that could potential fail.
Fixes #95713