Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DisplayServer] Implement has_hardware_keyboard method for Android and iOS. #97743

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 2, 2024

No description provided.

@Calinou
Copy link
Member

Calinou commented Oct 2, 2024

For context, this is needed to resolve #88235 in a way that doesn't harm usability when a physical keyboard is connected.

@bruvzg bruvzg marked this pull request as ready for review October 3, 2024 07:54
@bruvzg bruvzg requested review from a team as code owners October 3, 2024 07:54
@syntaxerror247
Copy link
Member

Just tested it on android and it is working properly.

@akien-mga akien-mga modified the milestones: 4.x, 3.x, 4.4 Oct 4, 2024
@akien-mga
Copy link
Member

Is this something that can be implemented for Web too, when using it on mobile devices?

@WhalesState
Copy link
Contributor

Is this something that can be implemented for Web too, when using it on mobile devices?

If we use this to return from (LineEdit/TextEdit) show_virtual_keyboard when DisplayServer::get_singleton()->has_hardware_keyboard() is true, it will never show the virtual keyboard on Web (android/ios) since it will always return true on Web.

@akien-mga
Copy link
Member

Yeah I'm fine merging this to have the feature for platforms that support it, but we need to be very careful before we rely on it for engine functionality. There are also Windows or Linux tablets with virtual keyboards where this would return true currently, even if no hardware keyboard is attached.

@akien-mga akien-mga merged commit 5ac62a6 into godotengine:master Oct 4, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants