Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LocalVector for skeleton #97744

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Use LocalVector for skeleton #97744

merged 1 commit into from
Oct 10, 2024

Conversation

Nazarwadim
Copy link
Contributor

Replaced in places that do not require COW behavior.

@Nazarwadim Nazarwadim requested review from a team as code owners October 2, 2024 17:11
@AThousandShips AThousandShips added this to the 4.x milestone Oct 2, 2024
@Nazarwadim Nazarwadim force-pushed the use_local_vector_for_skeleton branch from 95a011f to a9568f9 Compare October 2, 2024 17:30
@Nazarwadim Nazarwadim force-pushed the use_local_vector_for_skeleton branch from a9568f9 to 1ba168f Compare October 2, 2024 17:40
@fire fire requested a review from a team October 2, 2024 22:08
fire
fire approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a mechanical replacement of Vector to LocalVector with a fixup for ptrw. see the proposal for reasoning.

godotengine/godot-proposals#10594

@TokageItLab TokageItLab modified the milestones: 4.x, 4.4 Oct 7, 2024
@Repiteo Repiteo merged commit bb20444 into godotengine:master Oct 10, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 10, 2024

Thanks!

@Nazarwadim Nazarwadim deleted the use_local_vector_for_skeleton branch October 11, 2024 09:33
@Nazarwadim Nazarwadim mentioned this pull request Oct 14, 2024
Merged
@Alex2782 Alex2782 mentioned this pull request Mar 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement topic:animation
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Nazarwadim @Repiteo @fire @TokageItLab @AThousandShips