-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Add support for dark and tinted icon versions. #97789
Conversation
main/main.cpp
Outdated
GLOBAL_DEF_BASIC(PropertyInfo(Variant::STRING, "application/config/icon_dark", PROPERTY_HINT_FILE, "*.png,*.bmp,*.hdr,*.jpg,*.jpeg,*.svg,*.tga,*.exr,*.webp"), String()); | ||
GLOBAL_DEF_BASIC(PropertyInfo(Variant::STRING, "application/config/icon_tinted", PROPERTY_HINT_FILE, "*.png,*.bmp,*.hdr,*.jpg,*.jpeg,*.svg,*.tga,*.exr,*.webp"), String()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are only used for iOS, I would suggest putting them in the iOS export preset instead. We can still have logic so that all the specific advanced cuts can be inferred from a "base icon" that would be a non-advanced setting in the export preset.
If other platforms start having support for this kind of dark/tinted icons, then we could refactor and put it in the project settings, but for now I'd keep it local (like we've done for Android in #97517 for example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! |
Updates icon list and adds support for new iOS 18 dark and tinted icons.