Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AudioStreamPlayer.get_playback_position() always returning 0 when using AudioStreamInteractive #97806

Closed
wants to merge 1 commit into from

Conversation

KingTheFifth
Copy link
Contributor

@KingTheFifth KingTheFifth commented Oct 4, 2024

Fixes the problem mentioned in #97791. AudioStreamPlayer.get_playback_position() now returns the playback position of the current stream, or 0 if there is no current stream.

Bugsquad edit:

@KingTheFifth KingTheFifth requested a review from a team as a code owner October 4, 2024 10:18
@Chaosus Chaosus added this to the 4.4 milestone Oct 4, 2024
@adamscott adamscott self-assigned this Oct 4, 2024
@adamscott adamscott changed the title Fix AudioStreamPlayer.get_playback_position() always returning 0 when using AudioStreamInteractive Fix AudioStreamPlayer.get_playback_position() always returning 0 when using AudioStreamInteractive Oct 4, 2024
@adamscott adamscott requested a review from reduz October 4, 2024 13:50
@adamscott adamscott added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Oct 4, 2024
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the entire file. This makes sense to me on paper, but I have not tested.

@adamscott
Copy link
Member

See my #97791 (comment) about the issue.

@akien-mga
Copy link
Member

Closing based on #97791 (comment), it seems this is intended behavior (but that needs to be better documented).

@akien-mga akien-mga closed this Nov 12, 2024
@akien-mga akien-mga added archived and removed cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 12, 2024
@akien-mga akien-mga removed this from the 4.4 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using AudioStreamInteractive, AudioStreamPlayer.get_playback_position() always returns 0
6 participants