Improve detection of ccache on macOS #97810
Conversation
pafuent
force-pushed
the
getting_ccache_working_on_mac
branch
from
4b97022 to
a778070
Compare
AThousandShips
changed the title
pafuent
force-pushed
the
getting_ccache_working_on_mac
branch
from
a778070 to
1d3893c
Compare
|
Friendly remainder |
pafuent
force-pushed
the
getting_ccache_working_on_mac
branch
from
1d3893c to
c65b350
Compare
|
Friendly remainder |
pafuent
force-pushed
the
getting_ccache_working_on_mac
branch
from
c65b350 to
db3c8ec
Compare
There was a problem hiding this comment.
Code looks good to me.
Note that on my macOS system, CCACHE wasn't set by brew install ccache, so I opted to prepend PATH with its binaries from /opt/homebrew as advised by the post-install message. It works without this PR in this situation, but I think this PR still makes sense as not everyone would want to modify their PATH.
There was a problem hiding this comment.
Seems to be working fine, CCACHE usually is not set on macOS and wrappers are used instead (will work without this PR), but you can set it to /opt/homebrew/opt/ccache/bin/ccache (for homebrew install).
Compiler version checks need adjustment ("Couldn't parse CXX environment variable to infer compiler version."), I guess doesn't like space in the executable name.
@pafuent Could you look into fixing this too? |
akien-mga
changed the title
Before this commit, ccache where only used on Mac when `OSXCROSS_ROOT` was defined. Now, it could be used even when that envirnment variable is not defined.
pafuent
force-pushed
the
getting_ccache_working_on_mac
branch
from
db3c8ec to
7c4c110
Compare
|
Thanks! |
Before this commit, ccache where only used on Mac when
OSXCROSS_ROOTwas defined. Now, it could be used even when that environment variable is not defined.