Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemList - Fix right padding missing #97888

Merged
merged 1 commit into from
Oct 17, 2024
Merged

ItemList - Fix right padding missing #97888

merged 1 commit into from
Oct 17, 2024

Conversation

havi05
Copy link
Contributor

@havi05 havi05 commented Oct 6, 2024

Fixes a regression introduced in #97439.
Fixes #97886

@havi05 havi05 requested a review from a team as a code owner October 6, 2024 15:39
@timothyqiu timothyqiu added this to the 4.4 milestone Oct 6, 2024
timothyqiu
timothyqiu approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@timothyqiu timothyqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. ItemLists now have the same right padding as in 4.3.stable and previous 4.4.dev versions.

@clayjohn clayjohn merged commit be9e42c into godotengine:master Oct 17, 2024
19 checks passed
@clayjohn
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothyqiu timothyqiu timothyqiu approved these changes

Assignees
No one assigned
Labels
bug regression topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Right padding missing in ItemList
3 participants
@havi05 @clayjohn @timothyqiu