Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Button minimum size when disabled is toggled. #97897

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Fix Button minimum size when disabled is toggled. #97897

merged 1 commit into from
Nov 11, 2024

Conversation

WhalesState
Copy link
Contributor

@WhalesState WhalesState commented Oct 6, 2024 •
edited
Loading

@WhalesState WhalesState requested a review from a team as a code owner October 6, 2024 17:47
@Chaosus Chaosus added this to the 4.4 milestone Oct 6, 2024
@KoBeWi

This comment was marked as outdated.

Sign in to view
@WhalesState

This comment was marked as off-topic.

Sign in to view
bruvzg
bruvzg requested changes Oct 6, 2024
View reviewed changes
@WhalesState WhalesState marked this pull request as draft October 6, 2024 21:01
@WhalesState WhalesState changed the title Fix Button minimum size. Fix Button minimum size when disabled is toggled. Oct 7, 2024
@WhalesState WhalesState marked this pull request as ready for review October 7, 2024 15:22
@WhalesState WhalesState requested a review from bruvzg October 7, 2024 15:22
@WhalesState
Copy link
Contributor Author

WhalesState commented Oct 7, 2024 •
edited
Loading

I just have fixed the minimum size when disabled is toggled, since you already have fixed the other issues.

bruvzg
bruvzg approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with #95580 scene, seems to be working fine.

@WhalesState WhalesState marked this pull request as draft October 18, 2024 20:21
@WhalesState WhalesState deleted the button-min-size branch October 25, 2024 12:02
@KoBeWi
Copy link
Member

KoBeWi commented Oct 25, 2024

Why was this closed?

@markdibarry
Copy link
Contributor

It seems they moved to a different fork project of Godot and closed all of their PRs, so I assume they're up for grabs for anyone who wants to reopen them as a new PR.

@KoBeWi
Copy link
Member

KoBeWi commented Oct 25, 2024

Except not all were closed https://github.com/godotengine/godot/pulls/whalesstate 🤔

Some of the closed PRs were already approved and did not require further action. You can still restore the branch and reopen them.

@AThousandShips AThousandShips removed this from the 4.4 milestone Oct 25, 2024
@mounirtohami mounirtohami restored the button-min-size branch October 26, 2024 22:12
@WhalesState WhalesState reopened this Oct 26, 2024
@WhalesState WhalesState marked this pull request as ready for review October 26, 2024 22:21
@KoBeWi KoBeWi removed the archived label Oct 26, 2024
@KoBeWi KoBeWi added this to the 4.4 milestone Oct 26, 2024
@Repiteo Repiteo merged commit 16cd7b4 into godotengine:master Nov 11, 2024
39 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 11, 2024

Thanks!

@WhalesState WhalesState deleted the button-min-size branch November 12, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Cutting text in button StyleBox with Context Margins
7 participants
@WhalesState @KoBeWi @markdibarry @Repiteo @bruvzg @Chaosus @AThousandShips