Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about missing per-vertex-shading #97917

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

TheYellowArchitect
Copy link
Contributor

Followup to #83360

@TheYellowArchitect TheYellowArchitect requested a review from a team as a code owner October 7, 2024 11:18
@AThousandShips AThousandShips changed the title Tooltip update for per-vertex-shading Remove note about missing per-vertex-shading Oct 7, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 7, 2024
Calinou
Calinou previously requested changes Oct 7, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a note that needs to be removed in BaseMaterial3D:

doc/classes/BaseMaterial3D.xml:
  352  			Sets whether the shading takes place, per-pixel, per-vertex or unshaded. Per-vertex lighting is faster, making it the best choice for mobile applications, however it looks considerably worse than per-pixel. Unshaded rendering is the fastest, but disables all interactions with lights.
  353: 			[b]Note:[/b] Setting the shading mode vertex shading currently has no effect, as vertex shading is not implemented yet.
  354  		</member>

@TheYellowArchitect
Copy link
Contributor Author

Nice catch! 👍

@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 8, 2024

Changes look good to me. The commits need to be squashed into one before this can be merged. See here for one explanation on how to do do that.

@AThousandShips
Copy link
Member

And please update your commit message to be more descriptive, the title of the PR would be appropriate, using git commit --amend (after squashing)

@TheYellowArchitect TheYellowArchitect force-pushed the patch-1 branch 2 times, most recently from 72fa47f to e994c49 Compare October 17, 2024 18:00
@TheYellowArchitect
Copy link
Contributor Author

TheYellowArchitect commented Oct 17, 2024

Thank you both for the suggestions. I didn't expect the rebase to be that easy (instead of upstream/master basically master lol), nor that I can git commit --amend after doing a git push --force.

@Mickeon Mickeon dismissed Calinou’s stale review November 10, 2024 16:50

The aforementioned note has been removed.

@Repiteo Repiteo merged commit e7867a7 into godotengine:master Nov 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2024

Thanks! Congratulations on your first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants