Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve space management for EditorFileDialog #97941

Closed

Conversation

vPumpking
Copy link
Contributor

Move buttons related to the file view on the container above so that they take less horizontal space and make search bar similar to the one in FileDialog

see #97344 and #88673

@vPumpking vPumpking requested review from a team as code owners October 7, 2024 16:54
@vPumpking vPumpking force-pushed the editor_file_dialog_filter branch from ab8ffcc to fe2321f Compare October 7, 2024 16:56
@vPumpking
Copy link
Contributor Author

vPumpking commented Oct 7, 2024

I noticed a problem with the makedir button: on my screen, it's off the window due to the dir field being too large, but i can't find why
image

EDIT: the problem was here before I move the other buttons

@vPumpking
Copy link
Contributor Author

I will fix the check errors in 1 or 2 days

@TheYellowArchitect
Copy link
Contributor

May be related with #97886

Move buttons related to the file view on the container above so that they take less horizontal space and make search bar similar to the one in FileDialog
@vPumpking vPumpking force-pushed the editor_file_dialog_filter branch from fe2321f to b6ae8e8 Compare October 8, 2024 16:24
@vPumpking
Copy link
Contributor Author

checks need a restart

@AThousandShips
Copy link
Member

Please rebase to fix a CI problem

@vPumpking
Copy link
Contributor Author

vPumpking commented Oct 8, 2024

I'll have to report it to tomorrow

EDIT : I mean I'll do it later

@AThousandShips

This comment was marked as resolved.

@vPumpking
Copy link
Contributor Author

vPumpking commented Oct 9, 2024

This branch was based on the wrong repository, PR moved to #98022

@AThousandShips AThousandShips removed this from the 4.x milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants