Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the original Godot preset zoom modifier #97955

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

RobProductions
Copy link
Contributor

Fixes #97732

I think I changed the zoom modifier keys for the Godot navigation preset in #85331 to work around a code ordering issue at the time. The issue is no longer present so now we can change the default back to CTRL like it was in 4.3 rather than CTRL + SHIFT. Let me know if it looks good, thanks!

@RobProductions RobProductions requested a review from a team as a code owner October 7, 2024 21:29
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reasoning makes sense.

@fire fire requested a review from a team October 8, 2024 01:27
@Mickeon Mickeon removed the request for review from a team October 8, 2024 09:13
@Mickeon Mickeon added this to the 4.4 milestone Oct 8, 2024
@RobProductions RobProductions requested a review from a team as a code owner October 8, 2024 18:02
@RobProductions
Copy link
Contributor Author

One small thing I was reminded of is to update the Godot nav preset description in the EditorSettings doc file to reflect the new key controls, so I just updated the branch with that change :)

@Mickeon Mickeon removed the request for review from a team October 8, 2024 19:00
@akien-mga akien-mga changed the title Fix: Restore the original Godot preset zoom modifier Restore the original Godot preset zoom modifier Nov 12, 2024
@Repiteo Repiteo merged commit 9309b37 into godotengine:master Nov 12, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl + mouse middle button zoom doesn't work in 4.4 dev2, 3
4 participants