Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh MenuBar scene after child renamed in editor #97977

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

syntaxerror247
Copy link
Member

This PR updates the MenuBar node scene preview in editor after its child (PopupMenu) is renamed.
Fixes #97691

@syntaxerror247 syntaxerror247 requested a review from a team as a code owner October 8, 2024 14:55
@AThousandShips AThousandShips added bug topic:gui cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 8, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 8, 2024
bruvzg

This comment was marked as outdated.

@syntaxerror247

This comment was marked as resolved.

@syntaxerror247

This comment was marked as resolved.

@bruvzg
Copy link
Member

bruvzg commented Oct 9, 2024

I guess _refresh_menu_names is called for each item itself, so it should be fine as is.

@clayjohn clayjohn merged commit 80f0b33 into godotengine:master Oct 18, 2024
19 checks passed
@clayjohn
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming Children of MenuBar does not immediately update in the Scene preview
4 participants