-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tablet/Trackpad
3D navigation preset
#97985
Add Tablet/Trackpad
3D navigation preset
#97985
Conversation
The new mode needs to be documented in the settings docs |
3b70181
to
3f31d08
Compare
Thanks for the help! I've updated the docs and changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's worth being so explicit over this one editor setting. The other affected ones are listed at the bottom of the description.
This commit adds a new navigation preset called `Tablet/Trackpad` which enables "Emulate 3 Button Mouse" to more quickly set up good default keys for tablet users. It also adds support for mouse buttons 4 and 5 in the navigation settings which will be helpful if users want to customize 3D navigation further for specific pens/mice.
3f31d08
to
bd47e4f
Compare
@Mickeon Done, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on a MacBook Pro, it works as expected. The shortcuts with this preset make sense to me.
Thanks! |
Following up on the discussion from #85331 , if a user enables "emulate 3 button mouse" with the
Godot
preset, they will see the camera always orbit because theGodot
preset doesn't use any hotkey for orbit. Bringing in "Alt" as a fallback key for 3 button mouse users (which is what the code used to do) would eliminate their ability to customize the orbit button, so instead the idea of aTablet/Trackpad
preset seems to work much better.With this change, 3 button mouse is now tied to the navigation preset, so if you set the preset to
Tablet/Trackpad
it will enable 3 button mouse and also set the orbit key to "Alt" so that Tablet users have better default settings. I also added options and functionality for mouse buttons 4 and 5; none of the presets use this but this should allow users to customize 3D nav further for specific tablet pens or mice.With this, tablet and trackpad users can simply change the preset setting rather than changing "Emulate 3 button mouse" which should provide a clearer experience now that everything is customizable. Similarly, if someone changes "Emulate 3 button mouse" from the default the preset will change to
Custom
which should help clarify that they are going outside of the default options.One question I had about the presets: is it okay to keep pushing down theCustom
preset to a different number if we add more presets that go above it in the UI? I numbered them in this commit for clarity but say for example we add aBlender
preset in the future, is it okay for that to become element 4 withCustom
getting pushed to element 5? Or should I just reorderCustom
to be at the top now for better futureproofing?Thanks and let me know if there are any questions :)