Fix ScrollBar grabber mouse input ignores scroll content margins.

[WhalesState]

• Fixes: ScrollBar StyleBoxTexture Grabber only half usable? #98004

Fixes this, the grab area now will respect the left and top content margins.

Also ignoring the focus style content margins and using only the scroll style's one, to prevent the grabber from changing it's position when focused.

Before:

before.mp4

After:

after.mp4

[bruvzg]

Grab area seems to be still a bit off (red area works, the rest is still click-through):

[WhalesState]

Grab area seems to be still a bit off (red area works, the rest is still click-through):

The MRP that he has added includes expand margin for both left and right sides in the grabber, if you check it again, you will see that it's actually centered but the first and last 8 pixels can't be clicked. please test with this MRP after removing the expand margins test-scrollbar-grabber-main.zip and try to add some content margins for the scrolls.

The issue was explained in this comment #98004 (comment), The ScrollBar doesn't take the content margins into account for mouse input.

[KoBeWi]

I don't see any difference with and without this PR. The original MRP is still broken, the new MRP works properly without the fix. It would be nice to see some project that works incorrectly on master, but is fixed by this PR.

[WhalesState]

Here it is, this will show the issue when you try to drag the scroll-bar, the scroll style just have some margins, test with the current godot version and with this PR MRP.

scroll-bar-issue.mp4

[KoBeWi]

I confirmed that this fixes a bug, but not the linked issues.

Though there are some changes that I'm not sure about. Removing bg makes the margins of focus StyleBox ignored.

[WhalesState]

I confirmed that this fixes a bug, but not the linked issues.

Though there are some changes that I'm not sure about. Removing bg makes the margins of focus StyleBox ignored.

You can define the margins inside an empty stylebox, just test again in the current godot's dev branch with a focus style that has some content margins and you will see the grabber runs into a new position after you grab it. also we are using the scroll style by default inside input, so if i revert this change i will have to respect the focus style's margin inside the input function.

[WhalesState]

I don't see any difference with and without this PR. The original MRP is still broken, the new MRP works properly without the fix. It would be nice to see some project that works incorrectly on master, but is fixed by this PR.

This issue was mentioned in the linked issue, also i have helped him to fix the original issue. so we can close the issue after merging this PR.

[KoBeWi]

Makes sense.

[Repiteo]

Thanks!