-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextParagraph/Button] Add support for line spacing. #98036
Conversation
cdd31ae
to
9de2430
Compare
What's the unit of line spacing? Also, I think we should make it clear in the documentation whether "line spacing" here means:
|
Pixel.
It's additional spacing, not a total spacing, so in does not matter from what point it's measured. It's used in the same way existing
Edit: Added some extra info to the documentation for all of these. |
9de2430
to
3097125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. It makes sense to expose this in Button since multiline buttons are fully supported in 4.x.
Thanks! |
Fixes godotengine/godot-proposals#10476
Related proposal godotengine/godot-proposals#9778 (adds support to
TextParagraph
but not to all controls using it).