Clean up ResourceImporterTexture #98071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCube3310
force-pushed
the
res-import-tex-clean
branch
2 times, most recently
from
f4c04b8 to
8812034
Compare
fire
reviewed
Nov 13, 2024
fire
reviewed
Nov 13, 2024
BlueCube3310
force-pushed
the
res-import-tex-clean
branch
2 times, most recently
from
c0d6c98 to
5f7a288
Compare
Calinou
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Tested locally on https://github.com/godotengine/tps-demo (rebased on top of master 0f20e67), it works as expected. All textures import correctly, with the expected texture format.
Code looks good to me.
AThousandShips
approved these changes
Dec 3, 2024
BlueCube3310
force-pushed
the
res-import-tex-clean
branch
2 times, most recently
from
529d4f6 to
37a2905
Compare
akien-mga
reviewed
Dec 12, 2024
akien-mga
reviewed
Dec 12, 2024
akien-mga
reviewed
Dec 12, 2024
akien-mga
reviewed
Dec 12, 2024
akien-mga
reviewed
Dec 12, 2024
akien-mga
reviewed
Dec 12, 2024
akien-mga
reviewed
Dec 12, 2024
BlueCube3310
force-pushed
the
res-import-tex-clean
branch
from
37a2905 to
0400cbc
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResourceImporterTexture was kind of confusing to parse visually,
this PR attempts to resolve that by cleaning up the general flow of the code and moving some code blocks to their own functions.
It also optimizes certain parts of the image processing code, such as checking for the color channels only when compressing for VRAM.