Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong base directory when creating folder #98075

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix wrong base directory when creating folder #98075

merged 1 commit into from
Oct 30, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 10, 2024

Fixes #98045

@KoBeWi KoBeWi added this to the 4.4 milestone Oct 10, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner October 10, 2024 22:23
SaracenOne
SaracenOne approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM 👍

@matheusmdx matheusmdx mentioned this pull request Oct 23, 2024
Closed
@Repiteo Repiteo merged commit f8f9763 into godotengine:master Oct 30, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 30, 2024

Thanks!

@KoBeWi KoBeWi deleted the based_folder branch October 30, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@aaronfranke aaronfranke aaronfranke approved these changes

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[Master] Creating a new folder inside a subfolder displays the res:// root directory.
5 participants
@KoBeWi @Repiteo @fire @aaronfranke @SaracenOne