Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar mistake in Shortcut documentation #98081

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix grammar mistake in Shortcut documentation #98081

merged 1 commit into from
Oct 30, 2024

Conversation

ArjhanToteck
Copy link
Contributor

Apostrophes should not be used to form the plural under most conditions.

@ArjhanToteck ArjhanToteck requested a review from a team as a code owner October 11, 2024 04:52
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but it would be nice to squash the commits together, too. See the Pull Request Workflow.

@Mickeon Mickeon added this to the 4.4 milestone Oct 11, 2024
@Repiteo
Copy link
Contributor

Repiteo commented Oct 25, 2024

As Mickeon mentioned, this will require squashing to a single commit before it can be merged

@ArjhanToteck ArjhanToteck requested review from a team as code owners October 25, 2024 19:57
@ArjhanToteck
Copy link
Contributor Author

Done, they should all be merged

@Mickeon Mickeon removed request for a team October 26, 2024 11:44
@Mickeon Mickeon removed request for a team October 26, 2024 11:44
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something wrong happened, because this commit/PR is much more than just fixing a grammar mistake. Seemed to have some issues with Git.

@ArjhanToteck ArjhanToteck reopened this Oct 27, 2024
@ArjhanToteck
Copy link
Contributor Author

Should be fixed now.

@Mickeon Mickeon requested a review from adamscott October 27, 2024 20:42
@Repiteo Repiteo merged commit 4fb1700 into godotengine:master Oct 30, 2024
20 of 27 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants