Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Keep tag stack between append_text calls. #98082

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 11, 2024

Fixes #97965
Fixes #37774

Allow subsequent append_text calls to close tags opened by previous calls.

Note: push_* / pop can be used in between append_text calls, but not mixed:

Examples:
	# This will work.
	rtl.append_text("norm [b] bl");
	rtl.push_italics()
	rtl.add_text(" bi ")
	rtl.pop()
	rtl.append_text("bl [/b] norm")

	# This won't.
	rtl.push_italics()
	rtl.add_text("ital")
	rtl.append_text("[/i]norm")

@bruvzg bruvzg added this to the 4.4 milestone Oct 11, 2024
@bruvzg bruvzg requested a review from a team as a code owner October 11, 2024 06:23
@dustdfg
Copy link
Contributor

dustdfg commented Oct 11, 2024

I am not sure if there were some changes in richlabel since 4.2 and 4.3 but I think this pr also should be cherripicked if merged

@AThousandShips
Copy link
Member

I'd say this is an enhancement and a disruptive change so it isn't appropriate for cherry picking, it isn't a pure bug fix

@KoBeWi

This comment was marked as outdated.

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly.

@akien-mga
Copy link
Member

Needs rebase.

@bruvzg bruvzg force-pushed the rtl_keep_tag_stack branch from edf0886 to 4b23e50 Compare December 2, 2024 16:46
@Repiteo Repiteo merged commit c72fe8e into godotengine:master Dec 3, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants