Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Image #98084

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Clean up Image #98084

merged 1 commit into from
Nov 12, 2024

Conversation

BlueCube3310
Copy link
Contributor

This PR attempts to clean up the Image class by doing the following:

  • Removing unnecessary comments,
  • Grouping together similar parts of the code, which used to be scattered around the files,
  • Moving some never used inline functions from public to private,
  • Moving function definitions to the .cpp file.

@BlueCube3310 BlueCube3310 requested a review from a team as a code owner October 11, 2024 09:56
@AThousandShips AThousandShips added this to the 4.x milestone Oct 11, 2024
AThousandShips
AThousandShips approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise, I thin this is a worthwhile change even though noisy

@BlueCube3310 BlueCube3310 force-pushed the image-cleanup-v2 branch 2 times, most recently from c296e2f to 4f9e101 Compare October 11, 2024 10:10
@BlueCube3310 BlueCube3310 mentioned this pull request Oct 11, 2024
Merged
clayjohn
clayjohn approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup!

@clayjohn clayjohn modified the milestones: 4.x, 4.4 Nov 12, 2024
@Repiteo Repiteo merged commit d3c8e4e into godotengine:master Nov 12, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks!

@BlueCube3310 BlueCube3310 deleted the image-cleanup-v2 branch November 16, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:core
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@BlueCube3310 @Repiteo @clayjohn @AThousandShips