Remove playback fade-in and add comments to AudioServer
#98131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
AThousandShips
added
bug
topic:audio
topic:codestyle
cherrypick:4.2
adamscott
changed the title
AudioServer
adamscott
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
This looks fine. Thanks for salvaging the PR, @KeyboardDanni !
AThousandShips
approved these changes
Nov 5, 2024
Co-authored-by: Ellen Poe <ellen@ellenhp.me>
KeyboardDanni
force-pushed
the
remove_playback_fadein
branch
from
3fed304 to
e55ceeb
Compare
|
Thanks! |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #87064. Manually redid the changes on top of latest, with a few tweaks. Let me know if I missed anything.
Fixes #66452.