Show correct icons in remote object inspector (EditorDebuggerRemoteObject)

[jaydensipe]

Used to implement godotengine/godot-proposals#2084, used to fix #95209. <- Better implemented in #88427.

This commit allows the remote scene view to display custom icons from classes (annotated with @icon) and allows the remote object inspector to display the correct class icon for an Object. These help a lot with readability.

This commit allows the remote object inspector (EditorDebuggerRemoteObject) to display the correct class icon for an Object.

---

Before	After
Screen.Recording.2024-10-13.185549.mp4	Screen.Recording.2024-10-13.185222.mp4

[timothyqiu]

I think you can merge #98157 into this one. It is essentially the same as this one.

[timothyqiu]

I set the node's icon via @icon:

@icon("res://icon.svg")
extends Node2D

	Before	After	Expected
Remote Scene Tree	No Icon	No Icon	Icon
Remote Inspector	Icon	No Icon	Icon

Project: test.zip

[jaydensipe]

I set the node's icon via @icon:

@icon("res://icon.svg")
extends Node2D

Before After Expected
Remote Scene Tree No Icon No Icon Icon
Remote Inspector Icon No Icon Icon
Project: test.zip

So, I did a lot of looking into this; to fix your test you can declare a class_name like so, and it will work: (BUT...)

@icon("res://icon.svg")
extends Node2D
class_name Test2D

I just found out there was another PR (#88427) that implemented this... oops :P. Theirs works without declaring class_name so depending on if we want to merge that one or I can work on this one to implement that. Theirs also doesn't implement the EditorDebuggerRemoteObject fix, so I can wait until theirs gets merged to use some of their code to implement that better.

[CrayolaEater]

If implementation wise your fix is similar to mine then I don't think having 2 open PRs that solve the same problem is a good idea. Maybe create a PR only for the EditorDebuggerRemoteObject fix?

[jaydensipe]

If implementation wise your fix is similar to mine then I don't think having 2 open PRs that solve the same problem is a good idea. Maybe create a PR only for the EditorDebuggerRemoteObject fix?

Agreed, changed this PR into the EditorDebuggerRemoteObject fix, but if we need a new PR for some reason I can do that. I tested my changes with yours, and they worked good. BTW, your fix works for Autoload singleton scripts which is awesome and will help a ton with my projects.

[timothyqiu]

Currently, the node's icon is completely missing in the remote object inspector.

Using the test project from #98156 (comment)

[jaydensipe]

Currently, the node's icon is completely missing in the remote object inspector.

Using the test project from #98156 (comment)

Hey, #88427 has code in it that would fix the icon missing when not defining a class_name, so would we wait until that is merged to merge this?

[timothyqiu]

Works as expected with #88427 which should be merged first.

[Repiteo]

Thanks!