GDScript: Don't highlight unexposed classes

[HolonProduction]

Fixes #19834

[dalexeev]

I'm not sure this makes sense. Yes, the user can't use unexposed classes, but the user also can't define a custom class with that name, so in my opinion it makes sense to highlight it. Maybe a different color, though that's probably overkill.

[HolonProduction]

Using those names as class_name seems to work just fine, GDNative class name restrictions don't really seem relevant to GDScript highlighting IMO

[dalexeev]

[HolonProduction]

Now I wonder why it works with class_name 🤔 Seems a bit inconsistent

[HolonProduction]

Hmmmm I don't know what I did but all of a sudden it does not produce the error anymore

[dalexeev]

Nevermind, this is a bug in my test project. To some extent, it should work, because we have the following check:

godot/modules/gdscript/gdscript_analyzer.cpp

Lines 6216 to 6218 in 92e51fc

	bool GDScriptAnalyzer::class_exists(const StringName &p_class) const {
	return ClassDB::class_exists(p_class) && ClassDB::is_class_exposed(p_class);
	}

But still, naming a class or other identifier as a native class (whether it's exposed or not) is a bad idea, the user risks encountering strange bugs, since scopes and shadowing are not implemented very well.

[HolonProduction]

To be honest I'd just emit a warning if a user is doing that, and keep it out of the highlighting. Users won't understand the implication behind it just from highlighting, and if there is a warning I don't feel an extra highlight color would add much value.

[dalexeev]

To be honest I'd just emit a warning if a user is doing that, and keep it out of the highlighting. Users won't understand the implication behind it just from highlighting, and if there is a warning I don't feel an extra highlight color would add much value.

I think this makes sense. As far as I understand, the current assumption is that shadowing unexposed classes should work (and it does work to some extent, despite possible issues). If we decide to limit this, then we shouldn't rely on syntax highlighting alone. And we can always revisit syntax highlighting in the future.

[Repiteo]

Thanks!