Add System Locale layout direction for Control and Window
#98203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
approved these changes
Oct 15, 2024
timothyqiu
force-pushed
the
layout-dir-created-equal
branch
from
9b9ed92 to
99a3cc4
Compare
Repiteo
reviewed
Oct 16, 2024
timothyqiu
force-pushed
the
layout-dir-created-equal
branch
from
99a3cc4 to
009446a
Compare
Repiteo
approved these changes
Oct 21, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only the root node can use "Based on System Locale" as its layout direction (set via Project Settings). This difference creates complications when I try to simplify the logic of the layout directions.
This PR adds this option to other nodes (i.e.,
ControlandWindow).In accommodate to this change,
LAYOUT_DIRECTION_LOCALEis now deprecated in favor ofLAYOUT_DIRECTION_APPLICATION_LOCALE.