Don't flip playback control buttons in RTL layout #98222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the direction Play buttons facing are inconsistent in the editor when using RTL layout. Some are facing left while some are facing right.
According to resources online, playback control symbols represent the direction of the tape being played, so they don't require any change in RTL layout.1
This PR makes all play icons facing right.
For AnimationPlayer and SpriteFrames playback controls, the icons are not flipped currently. This PR makes the order of these buttons the same as in LTR layout.
Footnotes
https://m2.material.io/design/usability/bidirectionality.html#mirroring-elements ↩