Add descriptions to RDTextureFormat's methods #98264
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevPoodle
force-pushed
the
rd-texture-format-docs
branch
from
c917714 to
3771c59
Compare
DevPoodle
force-pushed
the
rd-texture-format-docs
branch
from
8aa4aea to
a0829dc
Compare
mhilbrunner
approved these changes
Nov 11, 2024
AThousandShips
approved these changes
Nov 11, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added descriptions for RDTextureFormat's add_shareable_format and remove_shareable_format methods. In testing these functions to make sure I properly understood them, I also realized that the description of RDTextureView's format_override property should be updated as well.
Here's a link to the relevant source code:
https://github.com/godotengine/godot/blob/master/servers/rendering/rendering_device.cpp#L723