Move transitions of textures from transfer workers to the graphics queue. #98271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this PR, seems to fix #98158 |
…ain graphics queue. Also adds a new possible texture layout and API trait to support a particular behavior in D3D12 where only the COMMON layout is supported in copy queues. Fixes godotengine#98158.
DarioSamo
force-pushed
the
d3d12-enhanced-barrier-fix
branch
from
b5c7d28 to
8c3e46b
Compare
Chaosus
approved these changes
Oct 18, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to effectively fix #98158.
When using enhanced barriers, it is not possible to transition to anything but the COMMON layout in D3D12 when using a copy queue. The fix is split in two separate steps: a new layout has been added to represent this type along with a new API trait that says whether copy queues can only use that layout, and any post-copy transitions are now pushed to the graphics queue on the next possible frame.
Requires #98086 to be merged first, as I built the PR on top of it to avoid the future merge conflict.