Remove "Using present mode" verbose prints in Vulkan and Direct3D 12 #98279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These messages were printed every time the swapchain was recreated (e.g. on viewport size change), which could easily end up spamming the output. The chosen present mode is already displayed when using the Print FPS project setting or command line argument.
DarioSamo
approved these changes
Oct 18, 2024
|
Agreed, we've got plenty of other ways to access this information anyway. |
clayjohn
approved these changes
Oct 28, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These messages were printed every time the swapchain was recreated (e.g. on viewport size change), which could easily end up spamming the output.
The chosen present mode is already displayed when using the Print FPS project setting or command line argument.
cc @DarioSamo - I remember discussing this recently on the Godot Contributors Chat.