Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when undo tile deletion in TileSetAtlasSourceEditor #98293

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix error when undo tile deletion in TileSetAtlasSourceEditor #98293

merged 1 commit into from
Oct 25, 2024

Conversation

timothyqiu
Copy link
Member

Undoing tile deletion in TileSetAtlasSourceEditor produces this error:

ERROR: Condition "terrain_set < 0" is true.
   at: set_terrain (scene/resources/2d/tile_set.cpp:6483)

set_terrain() should allow setting terrain to invalid (-1) when terrain_set is also invalid.

@timothyqiu timothyqiu added bug topic:editor cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 18, 2024
@timothyqiu timothyqiu added this to the 4.4 milestone Oct 18, 2024
@timothyqiu timothyqiu requested review from a team as code owners October 18, 2024 12:13
@timothyqiu timothyqiu requested a review from groud October 21, 2024 08:47
@clayjohn clayjohn merged commit e952651 into godotengine:master Oct 25, 2024
20 checks passed
@clayjohn
Copy link
Member

Thank you!

@timothyqiu timothyqiu deleted the emptiness-is-indeed-form branch October 25, 2024 04:02
@Spartan322 Spartan322 mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groud groud

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:2d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @clayjohn @groud