Use a shared copy of placeholder textures, tweak placeholder appearance #98294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
texture-placeholders-use-shared-copy
branch
from
d3f9466 to
59e81d7
Compare
Calinou
changed the title
Calinou
force-pushed
the
texture-placeholders-use-shared-copy
branch
from
59e81d7 to
547d69a
Compare
This reduces memory usage a bit in case multiple placeholders were requested, e.g. when using multiple NoiseTextures with no noise property defined. The placeholder texture's appearance was also changed from a plain magenta color to a checkerboard alternating between magenta and black pixels. This makes it easier to spot when the placeholder texture ends up being used in a complex scene (usually by accident). The texture's dimensions remain identical to keep the physical size identical in 2D.
Calinou
force-pushed
the
texture-placeholders-use-shared-copy
branch
from
547d69a to
35a20fa
Compare
clayjohn
approved these changes
Oct 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces memory usage a bit in case multiple placeholders were requested, e.g. when using multiple NoiseTextures with no noise property defined. This addresses a longstanding TODO in the codebase.
The placeholder texture's appearance was also changed from a plain magenta color to a checkerboard alternating between magenta and black pixels. This makes it easier to spot when the placeholder texture ends up being used in a complex scene (very likely by accident). The texture's dimensions remain identical to keep the physical size identical in 2D.
Preview
Decals and a FogVolume with a FogMaterial that uses an uninitialized NoiseTexture density map: