Fix iOS audio driver attempting to start output too early #98305
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
platform:ios
topic:audio
cherrypick:4.2
adamscott
approved these changes
Oct 22, 2024
bruvzg
approved these changes
Oct 23, 2024
|
Thank you! And congratulations on your first merged contribution!! 🥳 |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87560.
The code for audio output resuming when returning from the background in
OS_IOS::on_focus_incaused iOS builds to throw an error on startup, since the same function is also called on the initial launch, when not all the necessary components exist yet. This adds a null pointer check to prevent the invalid attempt. The audio output will still start once the AudioServer is initialized.