-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDS: Add support for loading layered textures #98322
DDS: Add support for loading layered textures #98322
Conversation
6c8ec0e
to
ca7971f
Compare
There are some unused variables.
|
ca7971f
to
9edd450
Compare
There's an issue with the quick load menu where the dds files don't show up, since it narrows down the search range to a specific resource class (like Texture2D), and doesn't recognize them by their parent type (Texture in this case) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected.
Testing project: test_dds_cubemap.zip
Before
Notice the resource type icon at the top. Here, it's loaded as a Texture2D. Only one face is imported.
Uncompressed | DXT5 |
---|---|
![]() |
![]() |
After
The DDS file is now loaded as a Cubemap automatically. Memory usage is multiplied by 6 because it's now importing all faces, not just one.
Uncompressed | DXT5 |
---|---|
![]() |
![]() |
PS: We should improve the Cubemap preview to allow choosing a face to view, or even have an interactive view like the material preview (except you'd be inside the box and the box would be unshaded, and with flipped faces).
This system is already in place, though it's not well-documented: left-click the cubemap preview and drag the cursor :) |
I've added a testing project for every texture type. It seems to work correctly, though now thumbnails are not generated and the aforementioned issue with the quick search menu persists |
9edd450
to
06195cd
Compare
Thank you! |
Adds support for loading layered DDS texture files.
Progress:
MRP: ddslayered.zip