Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exported typed dictionaries in .NET having an incorrect hint #98340

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix exported typed dictionaries in .NET having an incorrect hint #98340

merged 1 commit into from
Oct 21, 2024

Conversation

juanjp600
Copy link
Contributor

Cherry-picked and amended based on #97948 (comment)

The other fixes in #97948 need more work, but this commit should be ready to be evaluated independently.

@juanjp600 juanjp600 requested review from a team as code owners October 19, 2024 15:44
@KoBeWi KoBeWi added this to the 4.4 milestone Oct 19, 2024
raulsntos
raulsntos approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great. I checked and this matches the hint used by GDScript.

@Repiteo Repiteo merged commit 8be0061 into godotengine:master Oct 21, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2024

Thanks!

@juanjp600 juanjp600 deleted the dotnet-typed-dictionary-hint-fix branch October 21, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@juanjp600 @Repiteo @raulsntos @KoBeWi