Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using RID with in operator for Arrays and Dictionaries #98363

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Allow using RID with in operator for Arrays and Dictionaries #98363

merged 1 commit into from
Oct 25, 2024

Conversation

dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Oct 20, 2024

Fixes #97872

@dustdfg dustdfg requested a review from a team as a code owner October 20, 2024 12:34
@AThousandShips AThousandShips requested a review from a team October 20, 2024 14:36
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 20, 2024
dalexeev
dalexeev approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dustdfg
Allow use RID with in operator for Arrays and Dictionaries
Loading
Loading status checks…
ee5d908 
Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
@dustdfg dustdfg force-pushed the rid_in_operator_fix branch from b3e1da8 to ee5d908 Compare October 21, 2024 08:51
@AThousandShips AThousandShips changed the title Allow use RID with in operator for Arrays and Dictionaries Allow using RID with in operator for Arrays and Dictionaries Oct 21, 2024
@dustdfg
Copy link
Contributor Author

dustdfg commented Oct 21, 2024

I am not sure but this also could be nominated to cherry pick? If not why?

@dalexeev
Copy link
Member

I am not sure but this also could be nominated to cherry pick? If not why?

We avoid fixing minor bugs in patch releases due to the risk of regressions and just behavior changes. Each cherry-pick should be not only low-risk, but also important enough. Note that with each subsequent patch we are increasingly conservative, in x.y.1 we can do much more than in x.y.3.

In this particular case I see little risk. However, this adds new operators to extension_api.json, could this be a problem? CC @godotengine/gdextension

@dalexeev dalexeev added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Oct 21, 2024
@clayjohn clayjohn merged commit b4ba0f9 into godotengine:master Oct 25, 2024
20 checks passed
@clayjohn
Copy link
Member

Thank you!

@dustdfg dustdfg deleted the rid_in_operator_fix branch October 25, 2024 05:13
@Spartan322 Spartan322 mentioned this pull request Jan 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn

@dalexeev dalexeev

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:core
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Can not check if RID in an Array using in operator
4 participants
@dustdfg @dalexeev @clayjohn @AThousandShips