Add PackedArrayRef classes, instances of PackedArrayRefRAII. #98373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivorforce
force-pushed
the
packed-array-ref
branch
2 times, most recently
from
19edb4d to
a8774cb
Compare
|
I used the current naming pattern for the new reference objects, but a case could be made to name them with the c++ pattern ( |
|
Are you aware that the github actions cicd tests are failing? |
Ivorforce
force-pushed
the
packed-array-ref
branch
2 times, most recently
from
7586281 to
af931fb
Compare
Right, should be all fixed now :) |
Ivorforce
force-pushed
the
packed-array-ref
branch
from
af931fb to
4a84ec3
Compare
…mic Variant's PackedArray behavior as a ref counted shared ownership of a single instance PackedArray.
Ivorforce
force-pushed
the
packed-array-ref
branch
from
4a84ec3 to
ff7a397
Compare
This was referenced Oct 21, 2024
|
With #99201 merged, i now longer have a personal use-case for this PR. Therefore, i will close it. If another use case for exposing PackedArrayRef emerges, please open up a new PR based on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#10830.
The use-case of these new objects are explained in the proposal, but in short: They allow strongly typed in-place modification of Packed arrays. In-place modification without this PR is only possible through Variant's stringy interfaces.
This PR compiles, but I have not yet tested the behavior. In particular:
PackedArrayRefRAIIclasses should be especially useful in GDExtensions, and thus should be exposed to them. I have not not done this before yet so I'll have to take another look at that.