Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Update char_range.inc to Unicode 16 #98395

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Oct 21, 2024

Includes a minor refactor to char_utils.h, letting the functions support constexpr & applying proper argument names (cp_char). Also, added a note by the underscore codepoint in xid_start, as it's technically not in that collection.

@Repiteo Repiteo added this to the 4.4 milestone Oct 21, 2024
@Repiteo Repiteo requested a review from bruvzg October 21, 2024 20:12
@Repiteo Repiteo requested a review from a team as a code owner October 21, 2024 20:12
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not checked every range, but it looks fine.

@Repiteo Repiteo merged commit d3298fe into godotengine:master Oct 25, 2024
20 checks passed
@Repiteo Repiteo deleted the core/char-range-utils-update branch October 25, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants