Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce opacity of nodes with no shared transition when selecting an AnimationNodeStateMachine node #98402

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

vaner-org
Copy link
Contributor

@vaner-org vaner-org commented Oct 21, 2024

  • Closes 10976
  • Also adds this functionality when selecting transition lines

This is intended to help visibility when working with complex AnimationNodeStateMachine cases.
This PR is a companion to 98401, which makes the selection of overlapping transition lines unambiguous.

highlight-selected-neighbours.mp4

As this is my second PR, criticism and feedback would be very much appreciated. I was a bit clueless on header organization and function placement so please let me know what I did wrong.

@vaner-org vaner-org requested review from a team as code owners October 21, 2024 23:58
@AThousandShips AThousandShips changed the title When selecting an AnimationNodeStateMachine node, reduce opacity of every node it doesn't have transitions with Reduce opacity of nodes with no shared transition when selecting an AnimationNodeStateMachine node Oct 22, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Oct 22, 2024
@vaner-org
Copy link
Contributor Author

vaner-org commented Oct 22, 2024

In my last commit, I made it so that when a pair of transitions exist, selecting one also highlights the other.

both_transitions_highlighted

@Mickeon Mickeon requested a review from fire November 13, 2024 11:52
@fire
Copy link
Member

fire commented Nov 13, 2024

I'll bring this to the Godot Engine animation meeting later this week to review.

Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a reasonable improvement to the usability of the state machine editor. I would suggest squashing the commits into a single commit though before we merge it, as this is the preferred way of merging PRs.

@vaner-org vaner-org force-pushed the highlight-node-neighbours branch 2 times, most recently from 136d2b9 to 9af680d Compare December 1, 2024 01:55
@vaner-org
Copy link
Contributor Author

All done, ready for you.

…nimationNodeStateMachine node

Applied suggestions from code review
@vaner-org vaner-org force-pushed the highlight-node-neighbours branch from 4108fd7 to 366fa9f Compare December 1, 2024 12:51
@TokageItLab TokageItLab modified the milestones: 4.x, 4.4 Dec 1, 2024
@akien-mga akien-mga merged commit d6b20fd into godotengine:master Dec 2, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@vaner-org vaner-org deleted the highlight-node-neighbours branch December 5, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
6 participants